Overlap methods revised #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ved, how_to_overlaps half-way; join_ranges now resets index and preserve order of left object; count_overlaps, intersect, subtract_ranges now preserve order of left obj; nearest had bugs; cluster changed slack meaning for consistency
|
@endrebak I appreciate your feedback on this one, it's potentially a big change, and the last one before advertising this version |
|
I will have time to look at it 20. of May. |
|
Scratch that. I'll have to start looking at my Ph.D. then. Taking the month of June off to revise my Ph.D. and won't look at pyranges until after then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I built the last (?) how-to page, about overlap-related methods, and I corrected interfaces and functioning in response. Overview of changes:
Important: I changed the meaning for slack for consistency: now slack=0 means bookended intervals do not overlap in all methods. This required changes in max_disjoint, merge_overlaps, cluster